row: Add a check for integrity of neededValueColsByIdx in row fetcher #40844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The panic cockroachdb#40410 arises when a value in neededValueColsByIdx is out of bounds of the row buffer used in the fetcher. The length of the row buffer is equal to the number of columns in the table, so this panic is most likely caused by the neededValueColsByIdx containing an invalid column ID. To guard against this / have more information about debugging this in the future, we verify during fetcher setup that all the values in neededValueColsByIdx are within range of the table's row buffer. Fixes cockroachdb#40410. Release justification: Low risk assertion of valid behavior. Release note: None
|
This change is |
jordanlewis
approved these changes
Sep 19, 2019
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @jordanlewis)
|
bors r=jordanlewis |
Build failed |
|
bors r=jordanlewis |
craig bot
pushed a commit
that referenced
this pull request
Sep 19, 2019
40844: row: Add a check for integrity of neededValueColsByIdx in row fetcher r=jordanlewis a=rohany The panic #40410 arises when a value in neededValueColsByIdx is out of bounds of the row buffer used in the fetcher. The length of the row buffer is equal to the number of columns in the table, so this panic is most likely caused by the neededValueColsByIdx containing an invalid column ID. To guard against this / have more information about debugging this in the future, we verify during fetcher setup that all the values in neededValueColsByIdx are within range of the table's row buffer. Fixes #40410. Release justification: Low risk assertion of valid behavior. Release note: None Co-authored-by: Rohan Yadav <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The panic #40410 arises when a value in neededValueColsByIdx is out of
bounds of the row buffer used in the fetcher. The length of the row
buffer is equal to the number of columns in the table, so this panic is
most likely caused by the neededValueColsByIdx containing an invalid
column ID. To guard against this / have more information about debugging
this in the future, we verify during fetcher setup that all the values
in neededValueColsByIdx are within range of the table's row buffer.
Fixes #40410.
Release justification: Low risk assertion of valid behavior.
Release note: None