storage/reports: fix NPE in zone visiting #40735
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
darinpp
approved these changes
Sep 12, 2019
andreimatei
force-pushed
the
reports.fix-zone-visitor
branch
from
3f422d2 to
b24e2f7
Compare
|
TFTR! bors r+ |
Build failed (retrying...) |
We were inadvertently returning early from visitZones() without exhausting the hierarchy, resulting in NPE in the replication_stats visitor and I think wrong results in the critical localities visitor. Release note: None
andreimatei
force-pushed
the
reports.fix-zone-visitor
branch
from
b24e2f7 to
63ab5e6
Compare
Canceled |
|
fixed lint bors r+ |
Build failed (retrying...) |
Build failed |
|
Agent out of space
bors r+
…On Thu, Sep 12, 2019, 8:02 PM craig[bot] ***@***.***> wrote:
Build failed
- GitHub CI (Cockroach)
<https://teamcity.cockroachdb.com/viewLog.html?buildId=1484779&buildTypeId=Cockroach_UnitTests>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#40735?email_source=notifications&email_token=AAC4C4MB3DJPER3W4S2TBD3QJLKBZA5CNFSM4IWKECDKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6TTCNA#issuecomment-531050804>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAC4C4KBAPPTEIYW6R6ZFJDQJLKBZANCNFSM4IWKECDA>
.
|
craig bot
pushed a commit
that referenced
this pull request
Sep 13, 2019
40735: storage/reports: fix NPE in zone visiting r=andreimatei a=andreimatei We were inadvertently returning early from visitZones() without exhausting the hierarchy, resulting in NPE in the replication_stats visitor and I think wrong results in the critical localities visitor. Release note: None Co-authored-by: Andrei Matei <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were inadvertently returning early from visitZones() without
exhausting the hierarchy, resulting in NPE in the replication_stats
visitor and I think wrong results in the critical localities visitor.
Release note: None