-
Notifications
You must be signed in to change notification settings - Fork 3.9k
c-deps: bump rocksdb for safer LSM invariant checks #40712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
c-deps: bump rocksdb for safer LSM invariant checks #40712
Conversation
Picks up cockroachdb/rocksdb#49. Release note: None
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we need to enable force_consistency_checks
for this to have any effect?
Yes, I was planning to do it separately, though. |
🤷♂an extra bors pass wouldn't be my choice. |
They are somewhat independent - |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, didn't mean to hold up approval.
Plus doing it separately allows us to backport it to release-19.1 and release-2.1 using the backport tool, which we couldn't do if it includes a RocksDB version bump. Idk, I am also suffering from clicking around PRs too much, but can tolerate it for a little while longer. |
bors r+ |
40712: c-deps: bump rocksdb for safer LSM invariant checks r=ajkr a=ajkr Picks up cockroachdb/rocksdb#49. Release note: None Co-authored-by: Andrew Kryczka <[email protected]>
Build succeeded |
Picks up cockroachdb/rocksdb#49.
Release note: None