sql: add a syntax hint for ALTER PARTITION #40709
Conversation
|
This change is |
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @knz and @rohany)
pkg/sql/parser/sql.y, line 1512 at r1 (raw file):
err := errors.New("index wildcard unsupported in ALTER PARTITION ... OF TABLE") err = errors.WithHint(err, "try ALTER PARTITION <partition> OF INDEX <tablename>@*") return setErr(sqllex, err)
@knz Is this a reasonable way to return a syntax hint? I couldn't find other examples of this in sql.y.
|
Release justification: Low risk improvements to documentation and error messaging. |
There was a problem hiding this comment.
Reviewable status:
pkg/sql/parser/sql.y, line 1173 at r1 (raw file):
// // Commands: // -- Alter a single partition of a table or its indexes.
its unclear to me from the comments what the difference between this and alter partition of index is
| @@ -1499,6 +1505,12 @@ alter_zone_partition_stmt: | |||
| s.AllIndexes = true | |||
| $$.val = s | |||
| } | |||
| | ALTER PARTITION partition_name OF TABLE table_name '@' '*' error | |||
There was a problem hiding this comment.
You can (and should) test the hint reporting in parse_test.go, in TestParseError
yes 💯 |
If a user tries to modify multiple index partitions via ALTER PARTITION ... OF TABLE, they now receive a hint to use ALTER PARTITION ... OF INDEX instead. I also improved the help docs for `\h ALTER PARTITION` to specify how to use the wildcard syntax. Fixes cockroachdb#40387 Release note: None
solongordon
force-pushed
the
partition-wildcard-better-error
branch
from
b2c438f to
838cfa1
Compare
There was a problem hiding this comment.
Reviewable status:
pkg/sql/parser/sql.y, line 1173 at r1 (raw file):
Previously, rohany (Rohan Yadav) wrote…
its unclear to me from the comments what the difference between this and alter partition of index is
I changed around the wording a bit. Let me know if that helps.
pkg/sql/parser/sql.y, line 1508 at r1 (raw file):
Previously, knz (kena) wrote…
You can (and should) test the hint reporting in
parse_test.go, inTestParseError
Done.
|
lgtm |
|
bors r+ |
40709: sql: add a syntax hint for ALTER PARTITION r=solongordon a=solongordon If a user tries to modify multiple index partitions via ALTER PARTITION ... OF TABLE, they now receive a hint to use ALTER PARTITION ... OF INDEX instead. I also improved the help docs for `\h ALTER PARTITION` to specify how to use the wildcard syntax. Fixes #40387 Release note: None Co-authored-by: Solon Gordon <[email protected]>
Build succeeded |
If a user tries to modify multiple index partitions via ALTER PARTITION
... OF TABLE, they now receive a hint to use ALTER PARTITION ... OF
INDEX instead.
I also improved the help docs for
\h ALTER PARTITIONto specify how touse the wildcard syntax.
Fixes #40387
Release note: None