debug-zip: include raw job and schema info #40510
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
danhhz
approved these changes
Sep 5, 2019
thoszhang
approved these changes
Sep 5, 2019
|
Should we backport this to 19.1? |
The debug.zip already contains some human-readable schema info scraped from the admin API to help with query debugging, but this human-readable form is pretty far removed from the low-level, raw metadata (for example it doesn't include "dropped" tables that still exist). Being able to restore (via some creative inserts) the actual descriptors and jobs has proved instrumental in reproducing and troubleshooting some issues with long-running jobs and schema changes. This adds those raw tables, since they serve a different purpose from their human-readable counterparts. Release note: None
dt
force-pushed
the
debug-zip-descriptors
branch
from
8fdb1ad to
6f4bb9c
Compare
|
bors r+ |
Build failed (retrying...) |
craig bot
pushed a commit
that referenced
this pull request
Sep 5, 2019
40510: debug-zip: include raw job and schema info r=dt a=dt The debug.zip already contains some human-readable schema info scraped from the admin API to help with query debugging, but this human-readable form is pretty far removed from the low-level, raw metadata (for example it doesn't include "dropped" tables that still exist). Being able to restore (via some creative inserts) the actual descriptors and jobs has proved instrumental in reproducing and troubleshooting some issues with long-running jobs and schema changes. This adds those raw tables, since they serve a different purpose from their human-readable counterparts. Release note: None Co-authored-by: David Taylor <[email protected]>
Build succeeded |
|
I hadn't really considered back porting to 19.1 but I guess I don't see why not? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The debug.zip already contains some human-readable schema info scraped
from the admin API to help with query debugging, but this human-readable
form is pretty far removed from the low-level, raw metadata (for example
it doesn't include "dropped" tables that still exist).
Being able to restore (via some creative inserts) the actual descriptors
and jobs has proved instrumental in reproducing and troubleshooting some
issues with long-running jobs and schema changes. This adds those raw
tables, since they serve a different purpose from their human-readable
counterparts.
Release note: None