sql: Allow zone configs on offline tables #40285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
pbardea
force-pushed
the
offline-zone-config
branch
12 times, most recently
from
831a11d to
18de819
Compare
pbardea
force-pushed
the
offline-zone-config
branch
4 times, most recently
from
37e3634 to
5c3d432
Compare
|
Additional context: |
pbardea
force-pushed
the
offline-zone-config
branch
from
5c3d432 to
e2047af
Compare
dt
approved these changes
Aug 29, 2019
pbardea
changed the title
pbardea
force-pushed
the
offline-zone-config
branch
2 times, most recently
from
17fd2fe to
8095dc5
Compare
Zone configs should be allowed to be set for offline tables. The specific use case that this is targetting is to create a work-around for cockroachdb#39602. This is to allow for tables to start being restored, having the restored job paused and then making zone config changes on these offline tables. This change also refactors some methods to pass a ObjectLookupFlags struct rather than a lot of individual flags down. This is so if in the future another flag is added, the signature of the intermediary functions don't explode in size. It would also ensure that future changes won't need to go through this plumbing again. Release note: None
pbardea
force-pushed
the
offline-zone-config
branch
from
8095dc5 to
0d61b25
Compare
|
bors r=dt |
craig bot
pushed a commit
that referenced
this pull request
Aug 29, 2019
40285: sql: Allow zone configs on offline tables r=dt a=pbardea Zone configs should be allowed to be set for offline tables. The specific use case that this is targetting is to create a work-around for #39602. This is to allow for tables to start being restored, having the restored job paused and then making zone config changes on these offline tables. Release note: None 40344: exec: handle division by zero for decimal types r=rafiss a=rafiss Previously, when a decimal operation had a division by zero, we would return `errors.fundamental(division by zero)`. That results in the correct error message being shown to the user, but it does not have the appropriate PG error code. Release note: None Co-authored-by: Paul Bardea <[email protected]> Co-authored-by: Rafi Shamim <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zone configs should be allowed to be set for offline tables. The specific use
case that this is targetting is to create a work-around for #39602. This is to
allow for tables to start being restored, having the restored job paused and
then making zone config changes on these offline tables.
Release note: None