distsql: better trace events for joinreader #40212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
Ping.. this should take 2 minutes to review. |
Adding a few trace events per joinreader batch that were helpful to debug an issue. Release note: None
RaduBerinde
force-pushed
the
better-tracing-joinreader
branch
from
a93e77d to
3d1c34f
Compare
yuzefovich
approved these changes
Sep 3, 2019
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @solongordon)
solongordon
approved these changes
Sep 3, 2019
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Sep 4, 2019
40212: distsql: better trace events for joinreader r=RaduBerinde a=RaduBerinde Adding a few trace events per joinreader batch that were helpful to debug an issue. Release note: None Co-authored-by: Radu Berinde <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a few trace events per joinreader batch that were helpful to
debug an issue.
Release note: None