sql: add row lock modes; make FOR UPDATE a no-op #40206
Conversation
|
This change is |
There was a problem hiding this comment.
LGTM, but should we go ahead and make all of these no-ops instead of just FOR UPDATE? I think the same logic applies to all of these (except for the fact that FOR UPDATE appears to be far more commonly used than the others).
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @andy-kimball, @bdarnell, and @rytaft)
|
We can do that - I hadn't thought about the semantics of all of the other ones, which also seem subtle - but I think you're right that none of them are observably different when all transactions are serializable. |
This commit adds parsing for the row locking modes: FOR UPDATE, FOR NO KEY UPDATE, FOR SHARE, FOR KEY UPDATE. All return unimplemented errors, except for FOR UPDATE, which behaves as a no-op. Release note (sql change): support parsing the FOR UPDATE modifier on SELECT clauses, treating it as a no-op, since CockroachDB's transactions only operate in SERIALIZABLE mode.
There was a problem hiding this comment.
Reviewed 9 of 9 files at r1, 4 of 4 files at r2.
Reviewable status:
|
bors r+ |
40206: sql: add row lock modes; make FOR UPDATE a no-op r=jordanlewis a=jordanlewis This commit adds parsing for the row locking modes: FOR UPDATE, FOR NO KEY UPDATE, FOR SHARE, FOR KEY UPDATE. All return unimplemented errors, except for FOR UPDATE, which behaves as a no-op. Closes #6583. Added #40205 to track the remaining kinds of row locking. Release note (sql change): support parsing the FOR UPDATE modifier on SELECT clauses, treating it as a no-op, since CockroachDB's transactions only operate in SERIALIZABLE mode. Co-authored-by: Jordan Lewis <[email protected]>
Build succeeded |
This commit adds parsing for the row locking modes: FOR UPDATE, FOR NO
KEY UPDATE, FOR SHARE, FOR KEY UPDATE.
All return unimplemented errors, except for FOR UPDATE, which behaves as
a no-op.
Closes #6583.
Added #40205 to track the remaining kinds of row locking.
Release note (sql change): support parsing the FOR UPDATE modifier on
SELECT clauses, treating it as a no-op, since CockroachDB's transactions
only operate in SERIALIZABLE mode.