row: fix decoding bug with cfetcher and wide rows #39441
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CFetcher was failing to properly decode value columns of tables that had more than 8 columns due to an indexing bug that only manifested when the value tag (the column id and tag, encoded as a varint) was more than a single byte, which only occurs when the column id or type id is large enough. I'm not quite sure how this didn't come up before, since TPCH has tables with more than 8 columns. Release note: None
|
This change is |
yuzefovich
approved these changes
Aug 8, 2019
There was a problem hiding this comment.
Hm, yeah I'm also surprised we haven't hit this before.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @solongordon)
|
bors r+ tftr! |
craig bot
pushed a commit
that referenced
this pull request
Aug 8, 2019
39441: row: fix decoding bug with cfetcher and wide rows r=jordanlewis a=jordanlewis CFetcher was failing to properly decode value columns of tables that had more than 8 columns due to an indexing bug that only manifested when the value tag (the column id and tag, encoded as a varint) was more than a single byte, which only occurs when the column id or type id is large enough. I'm not quite sure how this didn't come up before, since TPCH has tables with more than 8 columns. Updates #38288. Release note: None Co-authored-by: Jordan Lewis <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CFetcher was failing to properly decode value columns of tables that had
more than 8 columns due to an indexing bug that only manifested when the
value tag (the column id and tag, encoded as a varint) was more than a
single byte, which only occurs when the column id or type id is large
enough.
I'm not quite sure how this didn't come up before, since TPCH has tables
with more than 8 columns.
Updates #38288.
Release note: None