opt: turn optimizer on in schema changer #39364
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The schema changer sets up a custom `SessionData`; it wasn't initializing the `OptimizerMode` field. This change sets it to On (which is normally the default). Release note: None
|
This change is |
|
This feels pretty fragile.. Maybe the right thing to do would be to call something like |
andreimatei
approved these changes
Aug 6, 2019
There was a problem hiding this comment.
LGTM
resetSessionVars() also sounds good to me (if it doesn't break anything :P )
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @andreimatei)
|
I'll merge this as is for now. bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Aug 6, 2019
39364: opt: turn optimizer on in schema changer r=RaduBerinde a=RaduBerinde The schema changer sets up a custom `SessionData`; it wasn't initializing the `OptimizerMode` field. This change sets it to On (which is normally the default). Release note: None Co-authored-by: Radu Berinde <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The schema changer sets up a custom
SessionData; it wasn'tinitializing the
OptimizerModefield. This change sets it to On(which is normally the default).
Release note: None