exec: don't panic on unhandled datum conversion #38607
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously GetDatumToPhysicalFn panicked if it encountered an unhandled Datum type. This could cause server panics during vectorized planning. I changed it to return an error instead so that the planner can gracefully fall back in these scenarios. Release note: None
|
This change is |
jordanlewis
approved these changes
Jul 2, 2019
complete! 1 of 0 LGTMs obtained
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Jul 3, 2019
38607: exec: don't panic on unhandled datum conversion r=solongordon a=solongordon Previously GetDatumToPhysicalFn panicked if it encountered an unhandled Datum type. This could cause server panics during vectorized planning. I changed it to return an error instead so that the planner can gracefully fall back in these scenarios. Release note: None Co-authored-by: Solon Gordon <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously GetDatumToPhysicalFn panicked if it encountered an unhandled
Datum type. This could cause server panics during vectorized planning. I
changed it to return an error instead so that the planner can gracefully
fall back in these scenarios.
Release note: None