importccl: fix fixtures import progress tracking #38485
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The total batches denominator was previously unset, so got the zero value. This caused us to add infinite progress, which was truncated at 100%. Release note: None
|
This change is |
tbg
approved these changes
Jun 27, 2019
dt
approved these changes
Jun 27, 2019
|
TFTRs! bors r=tbg,dt |
Build failed |
|
"Error while applying patch" bors r=tbg,dt |
craig bot
pushed a commit
that referenced
this pull request
Jun 27, 2019
38485: importccl: fix fixtures import progress tracking r=tbg,dt a=danhhz The total batches denominator was previously unset, so got the zero value. This caused us to add infinite progress, which was truncated at 100%. Release note: None Co-authored-by: Daniel Harrison <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The total batches denominator was previously unset, so got the zero
value. This caused us to add infinite progress, which was truncated at
100%.
Release note: None