cli: override system zone config in cockroach demo
#38323
Merged
+5
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
The demo is known to be a single-node cluster, so set the default number of replicas in the system zone config to 1. Fixes cockroachdb#38239 Release note: None
ajwerner
approved these changes
Jun 20, 2019
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @nvanbenschoten)
ajwerner
approved these changes
Jun 20, 2019
There was a problem hiding this comment.
Reviewable status:
nvanbenschoten
approved these changes
Jun 21, 2019
There was a problem hiding this comment.
Reviewable status:
|
TFTRs! bors r+ |
Build failed |
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Jun 21, 2019
38323: cli: override system zone config in `cockroach demo` r=jeffrey-xiao a=jeffrey-xiao The demo is known to be a single-node cluster, so set the default number of replicas in the system zone config to 1. Fixes #38239 Release note: None Co-authored-by: Jeffrey Xiao <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The demo is known to be a single-node cluster, so set the default number of replicas in the system zone config to 1.
Fixes #38239
Release note: None