workloadccl: fix multi-table fixture generation #37617
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was broken in f4a0350. Release note: None
|
This change is |
dt
approved these changes
May 21, 2019
|
TFTR! Merging now because I need this, but cc. @danhhz - you might be interested in the testing gap. bors r=dt |
craig bot
pushed a commit
that referenced
this pull request
May 21, 2019
37617: workloadccl: fix multi-table fixture generation r=dt a=nvanbenschoten This was broken in f4a0350. `workload fixtures make tpcc` was failing with: ~Error: pq: gs://cockroach-fixtures/workload/tpcc/version=2.1.0,fks=true,interleaved=false,seed=1,warehouses=1/order_line already contains a BACKUP file~ I'm surprised how long it took us to catch this. Are there tests that should have caught this? Perhaps the issue is that most nightly tests are overwriting existing fixtures. EDIT: `workload fixtures make tpcc` was failing with the following error, which better explains why this wasn't caught by existing tests (due to the overwriting mentioned above): ``` Error: fixture table not found: workload/tpcc/version=2.1.0,fks=true,interleaved=false,seed=1,warehouses=1/warehouse ``` Release note: None Co-authored-by: Nathan VanBenschoten <[email protected]>
Build succeeded |
|
We have a basic test, TestFixture, but it requires google storage so there isn't a great way to run it. It's triggered if the right env variables are set. (Also looks like it's a single table, so it wouldn't have caught this, but that doesn't matter if we can't run the test.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was broken in f4a0350.
workload fixtures make tpccwas failing with:Error: pq: gs://cockroach-fixtures/workload/tpcc/version=2.1.0,fks=true,interleaved=false,seed=1,warehouses=1/order_line already contains a BACKUP fileI'm surprised how long it took us to catch this. Are there tests that should have caught this? Perhaps the issue is that most nightly tests are overwriting existing fixtures.
EDIT:
workload fixtures make tpccwas failing with the following error, which better explains why this wasn't caught by existing tests (due to the overwriting mentioned above):Release note: None