exec: catch panics coming from colBatchScan operator #37294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
Previously, panics from colBatchScan operator would not be caught by CatchVectorizedRuntimeError since that operator lives in distsqlrun package. The operator is, however, a part of the vectorized engine, so these panics should be treated similar to the ones coming from exec package. Release note: None
|
TFTR! bors r+ |
craig bot
pushed a commit
that referenced
this pull request
May 3, 2019
37294: exec: catch panics coming from colBatchScan operator r=yuzefovich a=yuzefovich Previously, panics from colBatchScan operator would not be caught by CatchVectorizedRuntimeError since that operator lives in distsqlrun package. The operator is, however, a part of the vectorized engine, so these panics should be treated similar to the ones coming from exec package. Fixes: #37293. Release note: None Co-authored-by: Yahor Yuzefovich <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, panics from colBatchScan operator would not be caught
by CatchVectorizedRuntimeError since that operator lives in
distsqlrun package. The operator is, however, a part of the
vectorized engine, so these panics should be treated similar
to the ones coming from exec package.
Fixes: #37293.
Release note: None