util/metric: make Rate into a real metric #37248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
The metric package had a Rate type to track an exponential weighted moving average for a Rate but it was unclear how a caller would use it as a metric in a metric struct. This PR makes that Rate type into a real metric in anticipation of using it to track throughputs. Release note: None
ajwerner
force-pushed
the
ajwerner/rate-metric
branch
from
04f6be2 to
68f0bb7
Compare
nvanbenschoten
approved these changes
May 1, 2019
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
May 2, 2019
37248: util/metric: make Rate into a real metric r=ajwerner a=ajwerner The metric package had a Rate type to track an exponential weighted moving average for a Rate but it was unclear how a caller would use it as a metric in a metric struct. This PR makes that Rate type into a real metric in anticipation of using it to track throughputs. Release note: None Co-authored-by: Andrew Werner <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The metric package had a Rate type to track an exponential weighted moving
average for a Rate but it was unclear how a caller would use it as a metric
in a metric struct. This PR makes that Rate type into a real metric in
anticipation of using it to track throughputs.
Release note: None