rpc: don't leave poison zero-nodeID connections in pool #37204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
An optimiziation to share the `(target,remoteNodeID)` connection under a second name `(target,0)` backfired because we were never unregistering the latter, meaning that clients requesting `(target,0)` would be handed an eternally broken connection. See cockroachdb#37200. Release note (bug fix): Avoid a source of internal connectivity problems that would resolve after restarting the affected node.
tbg
added a commit
to tbg/cockroach
that referenced
this pull request
Apr 30, 2019
These tests are pretty janky, and can end up failing with a timeout and a deadlocked test, which is not something roachtest can really ever handle gracefully. Sprinkle more contexts around and set a statement timeout for the central query that is most likely to get stuck under the crucial lock that we think "causes" most of the deadlocks. Of course there is likely a real problem with CRDB, which this PR does nothing about. All that is (hopefully) achieved here is a clean failure mode. The failure prompting this PR is fixed by cockroachdb#37204, unfortunately it also turns out that the statement timeout added in this PR did not prevent the statement from hanging. It is probably still worth merging this. Release note: None
knz
approved these changes
Apr 30, 2019
There was a problem hiding this comment.
Nice find and elegant fix. I suppose this was precisely the kind of problem Peter was foreseeing when I initially made the change. I'm sorry I did not consider this before. LGTM in any case. Thank you!
Reviewed 2 of 2 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained
Well, I'm sorry I didn't see it in review :-) It happens. bors r=knz |
craig bot
pushed a commit
that referenced
this pull request
Apr 30, 2019
37204: rpc: don't leave poison zero-nodeID connections in pool r=knz a=tbg An optimiziation to share the `(target,remoteNodeID)` connection under a second name `(target,0)` backfired because we were never unregistering the latter, meaning that clients requesting `(target,0)` would be handed an eternally broken connection. See #37200. Release note (bug fix): Avoid a source of internal connectivity problems that would resolve after restarting the affected node. Co-authored-by: Tobias Schottdorf <[email protected]>
Build succeeded |
craig bot
pushed a commit
that referenced
this pull request
May 1, 2019
37205: roachtest: reduce hangs in acceptance-chaos tests r=andreimatei a=tbg These tests are pretty janky, and can end up failing with a timeout and a deadlocked test, which is not something roachtest can really ever handle gracefully. Sprinkle more contexts around and set a statement timeout for the central query that is most likely to get stuck under the crucial lock that we think "causes" most of the deadlocks. Of course there is likely a real problem with CRDB, which this PR does nothing about. All that is (hopefully) achieved here is a clean failure mode. The failure prompting this PR is fixed by #37204, unfortunately it also turns out that the statement timeout added in this PR did not prevent the statement from hanging. It is probably still worth merging this. Release note: None Co-authored-by: Tobias Schottdorf <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An optimiziation to share the
(target,remoteNodeID)connection under asecond name
(target,0)backfired because we were never unregisteringthe latter, meaning that clients requesting
(target,0)would be handedan eternally broken connection.
See #37200.
Release note (bug fix): Avoid a source of internal connectivity problems
that would resolve after restarting the affected node.