storage: fix potential panic tracing raft requests #37107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
ajwerner
force-pushed
the
ajwerner/raft-mu-for-proposal-ctx-in-try-abandon
branch
from
f7e6061 to
40aa71b
Compare
Before this PR, when using vmodule=raft >= 2, it was possible for concurrent proposal cancelation to lead to span being closed before logging an event. This PR adds a contract to ProposalData.ctx that after a proposal has been submitted to raft it can only be modified while holding the Replica.raftMu. This is acceptable because cancelation is not performance sensitive. The test reliably reproduced the panic when run under stress within a minute and has been run for 10 minutes after the change without a failure. Release note: None
ajwerner
force-pushed
the
ajwerner/raft-mu-for-proposal-ctx-in-try-abandon
branch
from
40aa71b to
4da0e1a
Compare
|
@nvanbenschoten gentle nudge. I also would like to backport this to 19.1. It's only possible with vmodule set to raft=2 or higher but it still seems worth fixing. |
nvanbenschoten
approved these changes
May 6, 2019
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained
|
bors r=nvanbenschoten |
craig bot
pushed a commit
that referenced
this pull request
May 7, 2019
37107: storage: fix potential panic tracing raft requests r=nvanbenschoten a=ajwerner Before this PR, when using vmodule=raft >= 2, it was possible for concurrent proposal cancelation to lead to span being closed before logging an event. This PR adds a contract to ProposalData.ctx that after a proposal has been submitted to raft it can only be modified while holding the Replica.raftMu. This is acceptable because cancelation is not performance sensitive. The test reliably reproduced the panic when run under stress within a minute and has been run for 10 minutes after the change without a failure. Co-authored-by: Andrew Werner <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, when using vmodule=raft >= 2, it was possible for concurrent
proposal cancelation to lead to span being closed before logging an event.
This PR adds a contract to ProposalData.ctx that after a proposal has been
submitted to raft it can only be modified while holding the Replica.raftMu.
This is acceptable because cancelation is not performance sensitive.
The test reliably reproduced the panic when run under stress within a minute
and has been run for 10 minutes after the change without a failure.