Skip to content

Get test data rework #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: dev
Choose a base branch
from
Draft

Get test data rework #463

wants to merge 3 commits into from

Conversation

dsweber2
Copy link
Contributor

Checklist

Please:

  • Make sure this PR is against "dev", not "main".
  • Request a review from one of the current epipredict main reviewers:
    dajmcdon.
  • Make sure to bump the version number in DESCRIPTION and NEWS.md.
    Always increment the patch version number (the third number), unless you are
    making a release PR from dev to main, in which case increment the minor
    version number (the second number).
  • Describe changes made in NEWS.md, making sure breaking changes
    (backwards-incompatible changes to the documented interface) are noted.
    Collect the changes under the next release number (e.g. if you are on
    0.7.2, then write your changes under the 0.8 heading).
  • Consider pinning the epiprocess version in the DESCRIPTION file if
    • You anticipate breaking changes in epiprocess soon
    • You want to co-develop features in epipredict and epiprocess

Change explanations for reviewer

make get_test_data retrieve a year by default, and make predict narrow down to the forecast_date

Magic GitHub syntax to mark associated Issue(s) as resolved when this is merged into the default branch

  • Resolves #{issue number}

@dajmcdon
Copy link
Contributor

@dsweber2 How important do you think this methodology is? Just a thought, but what if we

  1. deprecate this function completely;
  2. only call forecast() in examples (rather than predict());
  3. Inside of forecast(), just predict the entire training data, then filter to the reference date.

@dsweber2
Copy link
Contributor Author

if the fitting is expensive, it's probably best to predict as few days as possible (I've run into this with grf). Having something that handles that filtering is probably worthwhile.

That said, the most important part of this PR is definitely the filtering the output in the way predict runs so that it's only outputting forecasts for the right days. In practice that was the part that tripped me up more when avoiding get_test_data in exploration-tooling

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants