Skip to content

fix: update recipes internal function name #439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 13, 2025
Merged

fix: update recipes internal function name #439

merged 2 commits into from
Feb 13, 2025

Conversation

dshemetov
Copy link
Contributor

Checklist

Please:

  • Make sure this PR is against "dev", not "main".
  • Request a review from one of the current epipredict main reviewers:
    dajmcdon.
  • Make sure to bump the version number in DESCRIPTION and NEWS.md.
    Always increment the patch version number (the third number), unless you are
    making a release PR from dev to main, in which case increment the minor
    version number (the second number).
  • Describe changes made in NEWS.md, making sure breaking changes
    (backwards-incompatible changes to the documented interface) are noted.
    Collect the changes under the next release number (e.g. if you are on
    0.7.2, then write your changes under the 0.8 heading).
  • Consider pinning the epiprocess version in the DESCRIPTION file if
    • You anticipate breaking changes in epiprocess soon
    • You want to co-develop features in epipredict and epiprocess

Change explanations for reviewer

Magic GitHub syntax to mark associated Issue(s) as resolved when this is merged into the default branch

@dshemetov
Copy link
Contributor Author

dshemetov commented Feb 12, 2025

So our CI here is failing because it's still installing recipes 1.1.0 (the action uses RSPM which doesn't have the updated binary from today yet), but the CDC CI installs recipes 1.1.1. Running devtools::check() locally.

@dshemetov
Copy link
Contributor Author

Well one vignette is failing, but it's regarding step_growth_rate and changes in this PR.

When I run tests, a number of growth_rate related tests also fail, a few messages from recipes are different, which breaks snapshots. Everything else runs fine, so I think we should just merge this.

@dshemetov
Copy link
Contributor Author

I tested this script with this branch and it worked.

@dshemetov dshemetov merged commit 5496b84 into dev Feb 13, 2025
1 of 2 checks passed
@dshemetov dshemetov deleted the hotfix branch February 13, 2025 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in cdc_baseline_forecaster?
1 participant