Skip to content

287 surface step name #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Sep 30, 2024
Merged

287 surface step name #383

merged 12 commits into from
Sep 30, 2024

Conversation

dajmcdon
Copy link
Contributor

Checklist

Please:

  • Make sure this PR is against "dev", not "main".
  • Make sure to bump the version number in DESCRIPTION and NEWS.md.
    Always increment the patch version number (the third number), unless you are
    making a release PR from dev to main, in which case increment the minor
    version number (the second number).
  • Describe changes made in NEWS.md, making sure breaking changes
    (backwards-incompatible changes to the documented interface) are noted.
    Collect the changes under the next release number (e.g. if you are on
    0.7.2, then write your changes under the 0.8 heading).

Magic GitHub syntax to mark associated Issue(s) as resolved when this is merged into the default branch

Copy link
Contributor

@dshemetov dshemetov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I added the snapshot tests to the step_* tests as well to make sure the step is actually surfaced and scanned through those manually. Also resolved minor conflicts with dev branch and merged it in.

@dajmcdon dajmcdon merged commit 37f3ad0 into dev Sep 30, 2024
2 checks passed
@dajmcdon dajmcdon deleted the 287-surface-step-name branch September 30, 2024 21:20
@dshemetov
Copy link
Contributor

dshemetov commented Sep 30, 2024

Wasn't quite ready to merge this one, I have a few comments. Can handle in follow up PR.

@dajmcdon
Copy link
Contributor Author

You can revert if you like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Surface step name when reporting error
2 participants