-
Notifications
You must be signed in to change notification settings - Fork 10
287 surface step name #383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I added the snapshot tests to the step_* tests as well to make sure the step is actually surfaced and scanned through those manually. Also resolved minor conflicts with dev branch and merged it in.
Wasn't quite ready to merge this one, I have a few comments. Can handle in follow up PR. |
You can revert if you like. |
Checklist
Please:
DESCRIPTION
andNEWS.md
.Always increment the patch version number (the third number), unless you are
making a release PR from dev to main, in which case increment the minor
version number (the second number).
(backwards-incompatible changes to the documented interface) are noted.
Collect the changes under the next release number (e.g. if you are on
0.7.2, then write your changes under the 0.8 heading).
Magic GitHub syntax to mark associated Issue(s) as resolved when this is merged into the default branch