Skip to content

Leonlu2/kcdc #975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 20, 2022
Merged

Leonlu2/kcdc #975

merged 4 commits into from
Sep 20, 2022

Conversation

LeonLu2
Copy link
Collaborator

@LeonLu2 LeonLu2 commented Sep 18, 2022

closes #852

Prerequisites:

  • Unless it is a documentation hotfix it should be merged against the dev branch
  • Branch is up-to-date with the branch to be merged with, i.e. dev
  • Build is successful
  • Code is cleaned up and formatted

Summary

  • change the regions on kcdc page to ROK
  • added ecdc_regions.txt file to delphi-epidata/labels
  • link the regions in ecdc page to the added file
  • reformatted all tables which has the length below 150 chars after reformatting, making them more readable on all devices

2. format the tables which have < 150 chars per row after formation, to make code more readable for all editors
2. link the list of location labels to the added file in ecdc page
@LeonLu2 LeonLu2 requested a review from krivard September 18, 2022 01:07
Kazakhstan
Kosovo*
Kyrgyzstan
Latvia
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm are there some missing here? Spain is suspiciously absent.

@LeonLu2
Copy link
Collaborator Author

LeonLu2 commented Sep 20, 2022

Oh yes, I lost the other part of the region by accident... I just added them to the file and it should look nice now.

@LeonLu2 LeonLu2 requested a review from krivard September 20, 2022 00:16
Copy link
Contributor

@krivard krivard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation of regions for kcdc_ili and ecdc_ili.
2 participants