Skip to content

Fix bugs identified in staging tests #863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 3, 2022
Merged

Conversation

krivard
Copy link
Contributor

@krivard krivard commented Mar 1, 2022

While testing quidel deletions in staging, it became clear that we missed a few things in review...

Prerequisites:

  • Unless it is a documentation hotfix it should be merged against the dev branch
  • Branch is up-to-date with the branch to be merged with, i.e. dev
  • Build is successful
  • Code is cleaned up and formatted

Summary

  • add missing rowcount handling to database.py:Database.delete_batch()
  • add missing rowcount-unsupported logic to delete_batch.py:main()
  • add missing imports to delete_batch.py
  • add missing argument to delete_batch.py:handle_file()
  • add missing time_type logic to delete_batch.py:handle_file()
  • add missing arguments to handle_file() call in delete_batch.py:main()

@krivard krivard requested a review from chinandrew March 1, 2022 16:11
Co-authored-by: chinandrew <[email protected]>
@krivard krivard requested a review from chinandrew March 3, 2022 14:58
Copy link
Contributor

@chinandrew chinandrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: :shipit: :shipit:

@krivard krivard merged commit b007d77 into dev Mar 3, 2022
@krivard krivard deleted the krivard/fix_delete_batch branch March 3, 2022 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants