Skip to content

Update google-symptoms geo aggregation #786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 14, 2021
Merged

Conversation

krivard
Copy link
Contributor

@krivard krivard commented Dec 13, 2021

Addresses part of cmu-delphi/covidcast-indicators#1426

Prerequisites:

  • Unless it is a documentation hotfix it should be merged against the dev branch
  • Branch is up-to-date with the branch to be merged with, i.e. dev
  • Build is successful
  • Code is cleaned up and formatted

Summary

We're changing the way google-symptoms aggregates hhs and nation to be based on population-weighted average. It turns out neither of these were added to the documentation when they were added to the API 😕 so I've refactored that section a bit to be more clear about what source region is being used.

TODO: verify that this is, in fact, how the new weighted averages are being computed...

Copy link
Contributor

@jingjtang jingjtang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@krivard krivard merged commit 29bc8be into dev Dec 14, 2021
@krivard krivard deleted the krivard/gs-no-aggregations branch December 14, 2021 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants