Skip to content

js client npm: upgrade jest #754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 28, 2021
Merged

js client npm: upgrade jest #754

merged 1 commit into from
Oct 28, 2021

Conversation

krivard
Copy link
Contributor

@krivard krivard commented Oct 27, 2021

closes 2 open dependabot alerts on src/client/packaging/npm/package-lock.json:

Prerequisites:

  • Unless it is a documentation hotfix it should be merged against the dev branch
  • Branch is up-to-date with the branch to be merged with, i.e. dev
  • Build is successful
  • Code is cleaned up and formatted

Summary

Dependabot couldn't figure this one out on its own, but setting devDependencies.jest to ^27 seems to build okay with

$ npm ci
$ npm test
$ npm pack

(which I pulled out of the release workflow; I don't actually know what I'm doing in npm)

Copy link
Member

@sgratzl sgratzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

since we don't use any plugins an upgrade of jest should be fine

@krivard krivard merged commit 4a5497b into dev Oct 28, 2021
@krivard krivard deleted the krivard/dependabot-client branch October 28, 2021 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants