Skip to content

feat: add basis_shift param to /covidcast/trend #687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 19, 2021
Merged

feat: add basis_shift param to /covidcast/trend #687

merged 1 commit into from
Aug 19, 2021

Conversation

sgratzl
Copy link
Member

@sgratzl sgratzl commented Aug 19, 2021 •
edited
Loading

Prerequisites:

  • Unless it is a documentation hotfix it should be merged against the dev branch
  • Branch is up-to-date with the branch to be merged with, i.e. dev
  • Build is successful
  • Code is cleaned up and formatted

Summary

add "basis_shift" param to /covidcast/trend and /covidcast/trendseries to specify in both variants easily how many days/weeks the basis for the trend should be before the current date

@sgratzl sgratzl added the api change affect the API and its responses label Aug 19, 2021
@sgratzl sgratzl requested a review from krivard August 19, 2021 15:57
@sgratzl sgratzl self-assigned this Aug 19, 2021
krivard
krivard approved these changes Aug 19, 2021
View reviewed changes
Copy link
Contributor

@krivard krivard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sgratzl sgratzl merged commit 2942bac into dev Aug 19, 2021
@sgratzl sgratzl deleted the sgratzl/trend_shift_arg branch August 19, 2021 16:44
@krivard krivard mentioned this pull request Aug 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krivard krivard krivard approved these changes

Assignees

@sgratzl sgratzl

Labels
api change affect the API and its responses
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sgratzl @krivard