Signals dash generator: store a longer time series by using covidcast/coverage endpoint #665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melange396
previously approved these changes
Aug 4, 2021
| @@ -17,7 +18,9 @@ | |||
| from delphi.epidata.acquisition.covidcast.logger import get_structured_logger | |||
|
|
|||
|
|
|||
| LOOKBACK_DAYS_FOR_COVERAGE = 28 | |||
| LOOKBACK_DAYS_FOR_COVERAGE = 52 | |||
There was a problem hiding this comment.
out of curiousity, why 52?
There was a problem hiding this comment.
uhhh because I can't multiply 28 by 2, apparently
krivard
commented
Aug 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites:
devbranchdevSummary
Most of this PR is for switching the signals dashboard data generator over to the
covidcast/coverageendpoint instead of pulling the regional data and counting sizes in a massive groupby. Sincecoverageisn't available natively in the covidcast library (and won't be; that's all going into the new delphi_epidata library/ies) we have to do this by constructing the URL, callingpandas.read_csv, and parsing thetime_valuecolumn.With that change, it makes it less of a big deal to double the length of the coverage time series -- the true goal of this PR.