Skip to content

Covidcast logging #611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Jun 29, 2021
Merged

Covidcast logging #611

merged 15 commits into from
Jun 29, 2021

Conversation

zhuoran-Cheng16
Copy link
Contributor

Summary

Change print to structure logging format in the folder delphi/delphi-epidata/src/acquisition/covidcast

@sgratzl sgratzl added acquisition changes acquisition logic refactor Substantial projects to make the code do the same thing, better. labels Jun 25, 2021
@TaraLakdawala TaraLakdawala linked an issue Jun 25, 2021 that may be closed by this pull request
Convert print statements to structured logging in covidcast acquisition #610
Closed
krivard
krivard suggested changes Jun 25, 2021
View reviewed changes
Copy link
Contributor

@krivard krivard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good first pass; now layer in structure only where we need it

@zhuoran-Cheng16 zhuoran-Cheng16 requested a review from krivard June 28, 2021 15:25
krivard
krivard suggested changes Jun 28, 2021
View reviewed changes
Copy link
Contributor

@krivard krivard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice progress, nearly there

krivard
krivard approved these changes Jun 29, 2021
View reviewed changes
Copy link
Contributor

@krivard krivard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 nice work!

@krivard krivard merged commit dce532a into dev Jun 29, 2021
@krivard krivard deleted the covidcast-logging branch June 29, 2021 16:52
@krivard krivard mentioned this pull request Jun 30, 2021
Merged
@krivard krivard mentioned this pull request Jun 30, 2021
Closed
@melange396 melange396 mentioned this pull request Jul 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dshemetov dshemetov dshemetov left review comments

@krivard krivard krivard approved these changes

@melange396 melange396 Awaiting requested review from melange396

@TaraLakdawala TaraLakdawala Awaiting requested review from TaraLakdawala

Assignees
No one assigned
Labels
acquisition changes acquisition logic refactor Substantial projects to make the code do the same thing, better.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convert print statements to structured logging in covidcast acquisition
5 participants
@zhuoran-Cheng16 @melange396 @krivard @dshemetov @sgratzl