Fix covid hosp as_of to only return latest issue #602
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinandrew
commented
Jun 17, 2021
| with self.subTest(name='as_of with multiple issues'): | ||
| response = Epidata.covid_hosp('PA', 20201118, as_of=20201103) | ||
| self.assertEqual(response['result'], 1) | ||
| self.assertEqual(len(response['epidata']), 1) |
There was a problem hiding this comment.
this is the test that will fail with the old code, since it returns a length of 3.
Co-authored-by: Katie Mazaitis <[email protected]>
chinandrew
commented
Jun 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes
Prerequisites:
devbranchdevSummary
Bug fix: Previously as_of was returning all isues <= as_of date. This changes it to only return the latest issue <= as_of date