Skip to content

Moving fb_survey source into inactive folder #1390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 20, 2024

Conversation

tinatownes
Copy link
Collaborator

closes|addresses

Summary:

Prerequisites:

  • Unless it is a documentation hotfix it should be merged against the dev branch
  • Branch is up-to-date with the branch to be merged with, i.e. dev
  • Build is successful
  • Code is cleaned up and formatted

@tinatownes tinatownes requested a review from nmdefries February 15, 2024 19:52
Avoid tracking R studio config files
nmdefries
nmdefries previously approved these changes Feb 19, 2024
Copy link
Contributor

@nmdefries nmdefries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This builds and looks correct. I ran the linkchecker tool on the local site and the change didn't seem to break any links (we make links by referring to the position of the markdown source for a page; moving files around can break these links).

issues must be fixed before merging.




##Added by Tina to avoid tracking R studio config files
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: Nice! This is good practice. We are inconsistent with doing this, though, some of our repos do this and some don't.

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@nmdefries nmdefries self-requested a review February 20, 2024 17:24
@nmdefries nmdefries merged commit 25f0fbd into dev Feb 20, 2024
@nmdefries nmdefries deleted the ttownes/move-fb_survey-to-inactive branch February 20, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants