Skip to content

Added host to database connection #1211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 27, 2023
Merged

Added host to database connection #1211

merged 1 commit into from
Jun 27, 2023

Conversation

dmytrotsko
Copy link
Contributor

Summary:

Specified database host in database connection strings to avoid wrong database using.

Prerequisites:

  • Unless it is a documentation hotfix it should be merged against the dev branch
  • Branch is up-to-date with the branch to be merged with, i.e. dev
  • Build is successful
  • Code is cleaned up and formatted

@dmytrotsko dmytrotsko requested a review from melange396 June 26, 2023 19:23
melange396
melange396 previously approved these changes Jun 26, 2023
View reviewed changes
Copy link
Collaborator

@melange396 melange396 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dmytrotsko dmytrotsko force-pushed the EPID-65-fluview-fluview-clinical-data-stale branch from 5231b10 to 27ea881 Compare June 26, 2023 20:46
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dmytrotsko dmytrotsko requested a review from melange396 June 26, 2023 20:47
melange396
melange396 approved these changes Jun 26, 2023
View reviewed changes
Copy link
Collaborator

@melange396 melange396 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@melange396
Copy link
Collaborator

REMINDER: dont merge and release these changes until planning and timing for the migration is finalized (detailed in jira)

@melange396 melange396 mentioned this pull request Jun 26, 2023
Open
4 tasks
@dmytrotsko dmytrotsko merged commit 866ff00 into dev Jun 27, 2023
@dmytrotsko dmytrotsko deleted the EPID-65-fluview-fluview-clinical-data-stale branch June 27, 2023 18:02
@nolangormley nolangormley mentioned this pull request Jun 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melange396 melange396 melange396 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmytrotsko @melange396