Skip to content

Enhanced output for performance testing rig #1101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 1, 2023
Merged

Enhanced output for performance testing rig #1101

merged 2 commits into from
Mar 1, 2023

Conversation

rzats
Copy link
Contributor

@rzats rzats commented Feb 27, 2023 •
edited
Loading

Prerequisites:

  • Unless it is a documentation hotfix it should be merged against the dev branch
  • Branch is up-to-date with the branch to be merged with, i.e. dev
  • Build is successful
  • Code is cleaned up and formatted

Summary

Updates the performance testing rig to make its PR comment output a summary of the run, which looks like this:

Screenshot 2023-02-27 at 21 33 08

@rzats rzats requested review from melange396 and krivard and removed request for melange396 February 27, 2023 19:39
@rzats
Copy link
Contributor Author

rzats commented Feb 27, 2023 •
edited
Loading

Unsure if this will trigger the newer or older version of the GitHub Action, but:

/run performance test

E: nope, looks like the older version for now

@github-actions
Copy link
Contributor

✅ Performance tests complete! Click here to view results: https://github.com/cmu-delphi/delphi-epidata/actions/runs/4286183094

krivard
krivard previously approved these changes Feb 28, 2023
View reviewed changes
Copy link
Contributor

@krivard krivard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Can merge as-is; question identifies a possible opportunity to reduce some coupling

@rzats rzats requested a review from krivard March 1, 2023 14:06
@rzats
Copy link
Contributor Author

rzats commented Mar 1, 2023

@krivard requesting a re-review since I applied the change that reduced some repetitive code

krivard
krivard approved these changes Mar 1, 2023
View reviewed changes
Copy link
Contributor

@krivard krivard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Solid!

@rzats rzats merged commit b877dbc into dev Mar 1, 2023
@rzats rzats deleted the rzatserkovnyi/performance-testing-rig-output branch March 1, 2023 15:12
@krivard krivard mentioned this pull request Mar 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krivard krivard krivard approved these changes

@melange396 melange396 Awaiting requested review from melange396

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rzats @krivard