-
Notifications
You must be signed in to change notification settings - Fork 67
Fix packages incompatibility with Apple M1 by defaulting to linux/amd64 containers #1080
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, and thankyou for keeping the line lengths reasonable 🙏
Verified running on my machine with these changes does not affect running time for make all test
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks pretty good! two things though:
-
(nit) it helps readability and is a good convention to put a space before each line-continuation backslash.
-
(todo) you should make the
--platform linux/amd64
optional so that non-m1 environments arent forced to use it by default -- platform auto-selection seems to work properly for all but the m1 mac environment. you could make anm1
argument to force this behavior (see thepdb
argument for reference), or even use the output of the commanduname -smp
to make that determination for you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 fulfills request for command-line switch
probably the change to pdb handling was unintentional and can be fixed directly from the suggestion; if it was on purpose can you say more about what you need it to do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix the pdb
thing, and it looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
automatic! awesome!!!
i would put an @echo
line inside your ifeq
block that prints something like "Apple M1 environment detected, using 'linux/amd64' platform for compatibility", so that its more obvious that the alternative platform is being used. but other than that, this is great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
excellent work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 great adjustments!
Summary
Due to package incompatibility, this PR adjusts the Makefile to build and run affected containers using linux/amd64 by default.
Testing
Local make all and make tests has no error and takes around 50s on my M1 macbook.
