-
Notifications
You must be signed in to change notification settings - Fork 67
a few "requirements" changes for #1043 #1046
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dshemetov
merged 4 commits into
ds/merge-docker-web-python
from
ds/merge-docker-web-python__george
Dec 5, 2022
Merged
a few "requirements" changes for #1043 #1046
dshemetov
merged 4 commits into
ds/merge-docker-web-python
from
ds/merge-docker-web-python__george
Dec 5, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
- rename requirements.txt to requirements.api.txt - merge dev/docker/python/requirements.txt with requirements.dev.txt - deduplicate packages in requirements.api.txt and requirements.dev.txt - pin packages in requirements.dev.txt and remove unused
dshemetov
approved these changes
Dec 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 🚀 🚀
went ahead and merged dev/docker/python/requirements.txt
with requirements.dev.txt
, deduplicated packages, and pinned their versions.
dshemetov
added a commit
that referenced
this pull request
Dec 5, 2022
* sorted requirements.txt files * removed duplicated requirements from ./dev/docker/python/requirements.txt * reduce runs of "pip install" when creating "delphi_web_python" docker image * renamed requirements.txt to requirements.api.txt * merge dev/docker/python/requirements.txt with requirements.dev.txt * deduplicate packages in requirements.api.txt and requirements.dev.txt * pinned packages in requirements.dev.txt and removed unused Co-authored-by: Dmitry Shemetov <[email protected]>
dshemetov
added a commit
that referenced
this pull request
Dec 5, 2022
* sorted requirements.txt files * removed duplicated requirements from ./dev/docker/python/requirements.txt * reduce runs of "pip install" when creating "delphi_web_python" docker image * renamed requirements.txt to requirements.api.txt * merge dev/docker/python/requirements.txt with requirements.dev.txt * deduplicate packages in requirements.api.txt and requirements.dev.txt * pinned packages in requirements.dev.txt and removed unused Co-authored-by: Dmitry Shemetov <[email protected]>
dshemetov
added a commit
that referenced
this pull request
Dec 6, 2022
- remove delphi_python Docker image - merge operations repo delphi_python Dockerfile into delphi_web_python - copy Python requirements file to this directory and merge with requirements.dev.txt - copy setup.sh to this directory - renamed requirements.txt to requirements.api.txt - remove unused Docker commands from CI - merge requirements files and pin versions and sort and remove unused packages (#1046) Co-authored-by: melange396 <[email protected]> Co-authored-by: Dmitry Shemetov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3 commits:
note that these are untested, ci is still running