Reformat NSSP county zip code #1976
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minhkhul
changed the title
dsweber2
approved these changes
Jun 18, 2024
| "hsa": "Denver (Denver), CO - Jefferson, CO", | ||
| "hsa_counties": "Adams, Arapahoe, Clear Creek, Denver, Douglas, Elbert, Gilpin, Grand, Jefferson, Park, Summit", | ||
| "hsa_nci_id": "688", | ||
| "fips": "8059", |
There was a problem hiding this comment.
just confirming, this is a test example with 4 rather than 5 digits to make sure it bumps to 5?
This was referenced Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testing NSSP on staging shows some NSSP geo_ids at county level don't match what's expected in our db and so cannot be ingested. This is because our db takes 5-digit zip codes (e.g. 08059), while nssp source may note the same county down with 4-digit (8059).
This fix adds a leading 0 all 4-digit zip codes present in nssp source.
Changelog
This fix adds a leading 0 all 4-digit zip codes present in nssp source when pulling from API.