first attempt at fixing broken backfill build #1958
Conversation
dshemetov
force-pushed
the
backfillCI_fix
branch
from
d87f8f8 to
486b925
Compare
* pin to rocker/tidyverse:4.2 * update Dockerfile to use pak and rspm for package installation * add workflow_dispatch button
* simplify caching (r-lib/setup-r-dependencies caches by default) * switch to Ubuntu latest * keep R on 4.2
dshemetov
force-pushed
the
backfillCI_fix
branch
from
486b925 to
3022a90
Compare
| if: github.event.pull_request.draft == false | ||
| strategy: | ||
| matrix: | ||
| r-version: [4.2.1] |
There was a problem hiding this comment.
suggestion (optional): maybe we want to keep the matrix way of providing r-version for future flexibility? In some other packages, we specify several different R versions to run tests on.
There was a problem hiding this comment.
Let's just add that in when we need it, CI-wise it'll be about the same amount of work then.
| id: get-date | ||
| run: | | ||
| echo "::set-output name=date::$(/bin/date -u "+%Y%m%d")" | ||
| - name: Cache R packages |
There was a problem hiding this comment.
praise:
setup-r-dependencies already caches, so no need for the caching action
Nice! Good simplification here and above.
| use-public-rspm: true | ||
| - name: Install linux dependencies | ||
| run: | | ||
| sudo apt-get install \ |
There was a problem hiding this comment.
question: we don't need this section because r-lib/actions/setup-r-dependencies@v2 installs using pak, which as you mentioned above also installs dependencies?
There was a problem hiding this comment.
Description
The buildprocess in #1957 broke seemingly caused by an update to the R version. This should fix that.
Changelog
rocker/tidyverse:4.2pakandrspmto install dependencies via binaries (removed system dependencies install command becausepaktakes care of those), should speed things upbackfill-corr-ci.yml(setup-r-dependencies already caches, so no need for the caching action)