[Refactor] Add type hints to geomap.py and a small test refactor
#1706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dshemetov
force-pushed
the
ds/geomap-refactor
branch
2 times, most recently
from
ce92b28 to
7f2dcb5
Compare
krivard
reviewed
Apr 10, 2023
krivard
reviewed
Apr 10, 2023
|
I'd say refresh. I did this because I was working geomapper at some point and the lack of argument types was confusing my IDE. |
|
alright, when you get a minute, rebase onto main to bring it back up to date, then i'll tag nat for a review |
dshemetov
changed the title
geomap.pygeomap.py and a small test refactor
dshemetov
force-pushed
the
ds/geomap-refactor
branch
4 times, most recently
from
dc21376 to
75a3c14
Compare
nmdefries
approved these changes
Jun 21, 2023
dshemetov
force-pushed
the
ds/geomap-refactor
branch
2 times, most recently
from
291e316 to
ef7c314
Compare
dshemetov
force-pushed
the
ds/geomap-refactor
branch
from
ef7c314 to
d4b056e
Compare
|
praise: good job finishing this off! |
This was referenced Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
geomap.py_delphi_utilsChangelog
You can see the changes in the commit log.
Also adds
.git-blame-ignore-revs, which you can use to ignore the changes in the83cb164commit (or whatever commits you paste into it) when usinggit blame(idea taken fromblackdocumentation). If you're a GitLens user, here's the solution.