Skip to content

optimize: new implementation of gonet transport #1767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

ppzqh
Copy link
Contributor

@ppzqh ppzqh commented Apr 23, 2025

What type of PR is this?

optimize

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

Copy link

codecov bot commented Apr 23, 2025

Codecov Report

Attention: Patch coverage is 53.31325% with 155 lines in your changes missing coverage. Please review.

Project coverage is 59.81%. Comparing base (85cfe2e) to head (c2f065b).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
internal/mocks/bufiox/bufreader.go 0.00% 57 Missing ⚠️
pkg/remote/trans/gonet/trans_server.go 67.27% 17 Missing and 1 partial ⚠️
pkg/remote/connpool/long_pool.go 63.15% 13 Missing and 1 partial ⚠️
pkg/remote/trans/gonet/bytebuffer.go 73.46% 8 Missing and 5 partials ⚠️
internal/remote/conn_check.go 65.71% 8 Missing and 4 partials ⚠️
pkg/remote/trans/nphttp2/grpc/framer.go 54.54% 10 Missing ⚠️
pkg/remote/trans/gonet/dialer.go 0.00% 7 Missing ⚠️
pkg/remote/trans/nphttp2/server_handler.go 66.66% 5 Missing and 2 partials ⚠️
pkg/remote/trans/gonet/conn.go 70.00% 6 Missing ⚠️
internal/client/option.go 57.14% 2 Missing and 1 partial ⚠️
... and 3 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1767      +/-   ##
===========================================
+ Coverage    59.77%   59.81%   +0.04%     
===========================================
  Files          382      385       +3     
  Lines        34595    34784     +189     
===========================================
+ Hits         20679    20806     +127     
- Misses       12655    12703      +48     
- Partials      1261     1275      +14     
Flag Coverage Δ
integration 47.75% <30.43%> (-0.10%) ⬇️
unit 50.18% <50.60%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ppzqh ppzqh force-pushed the new_gonet branch 3 times, most recently from 094e37b to 07ac048 Compare May 2, 2025 03:55
@ppzqh ppzqh marked this pull request as ready for review May 2, 2025 06:15
@ppzqh ppzqh requested review from a team as code owners May 2, 2025 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant