Skip to content

Fix #3010 - middleware error on invalid keywords #3016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 18, 2021

Conversation

yuhan0
Copy link
Contributor

@yuhan0 yuhan0 commented May 14, 2021

Fixes #3010 - cider-tooling-eval does not throw middleware errors if the keyword is invalid.


Before submitting the PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):

  • The commits are consistent with our contribution guidelines
  • You've added tests (if possible) to cover your change(s)
  • All tests are passing (eldev test)
  • All code passes the linter (eldev lint) which is based on elisp-lint and includes
  • You've updated the changelog (if adding/changing user-visible functionality)
  • You've updated the user manual (if adding/changing user-visible functionality)

Thanks!

If you're just starting out to hack on CIDER you might find this section of its
manual
extremely useful.

@yuhan0 yuhan0 marked this pull request as draft May 14, 2021 11:16
@bbatsov
Copy link
Member

bbatsov commented May 14, 2021

The change seems reasonable, but it's breaking the tests.

@yuhan0
Copy link
Contributor Author

yuhan0 commented May 14, 2021

I think this should work now.. but it's quite ugly to be requiring all these external repl-related functions from a util namespace.

I originally made this change to better support cider-browse-spec on the common use of auto namespaced ::keyword specs - perhaps the logic should belong there instead.

@yuhan0
Copy link
Contributor Author

yuhan0 commented May 16, 2021

Added commits which revert all the changes to cider-symbol-at-point and move the :: expansion logic to cider-browse-spec (which doesn't have tests), let me know which you prefer and I'll squash the relevant commits

@bbatsov
Copy link
Member

bbatsov commented May 18, 2021

@yuhan0 I like the second solution better, so let's go with it.

@yuhan0 yuhan0 force-pushed the fix-symbol-macroexpand branch from 35b1376 to d6e1e85 Compare May 18, 2021 09:51
@yuhan0 yuhan0 marked this pull request as ready for review May 18, 2021 09:51
@bbatsov bbatsov merged commit eccfcea into clojure-emacs:master May 18, 2021
@bbatsov
Copy link
Member

bbatsov commented May 18, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken keyword results in middleware error
2 participants