Skip to content

fix github login #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 31, 2023
Merged

fix github login #259

merged 1 commit into from
Oct 31, 2023

Conversation

sgrtye
Copy link
Contributor

@sgrtye sgrtye commented Oct 30, 2023

Resolved GitHub 2FA Login Issue for OTP Generated by Authenticator App

I have successfully addressed the GitHub login issue related to 2FA authentication when utilizing OTPs generated by the Authenticator app. To ensure seamless functionality, it is now imperative for users to have the Authenticator app as their preferred 2FA method. Please note that support for SMS/Github Mobile 2FA to be added in the future upon request.

@sgrtye
Copy link
Contributor Author

sgrtye commented Oct 30, 2023

Although the current implementation only works for the Authenticator app method, it is better than the broken one.

@sgrtye
Copy link
Contributor Author

sgrtye commented Oct 30, 2023

另外ISSUE_TEMPLATE中[To Reproduce(重现)]第二行多了一个a
这个提PR有点呆 望作者自行修改了

@ccagml ccagml merged commit 48c12d7 into ccagml:main Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants