-
Notifications
You must be signed in to change notification settings - Fork 172
Redesign module options #196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
- git.hooks.pre-commit.shellcheck.enable = true;
+ hooks.pre-commit.shellcheck.enable = true; This way devenv can import it using Anyway, another nice thing would be to do {
options.hooks = mkOption {
type = submodule {
freeformType = types.attrsOf hookModule;
};
};
} and then declare built in hooks as something like {
options.hooks.nixpkgs-fmt = mkOption {
type = submodule {
imports = [ hookModule ];
options.some-setting = mkOption ...;
};
};
} thereby adding the individual hooks in the option docs, and removing the need for a separate settings namespace. |
The redesigned pattern should have a |
Eventually I'd like the interface to be:
|
Merged to master! |
Based on cachix#196.
Something like:
cc @roberth
The text was updated successfully, but these errors were encountered: