-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Clippy emits some warnings on the nightly toolchain #2698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Which rustc version are you using? If you are using beta or nightly clippy probably added a new lint or changed one to trigger in more cases. |
You're right, I was using the nightly (1.56). When I switched back to 1.54 the error went away. The getting started guide does list switching to nightly as a way to improve compilation times, so maybe this should still be fixed? |
Yep, we should have a warning that small things of this nature may be broken when using nightly. That belongs in the book IMO, over on https://github.com/bevyengine/bevy-website. |
As of the last rust update the false positive for collapsible-match on the nightly toolchain have been fixed. I update my pr to remove the #allows, and performing the steps from CONTRIBUTING.md no longer gives any errors:
|
I forked the repo to contribute and was reading through CONTRIBUTE.md, one of the steps instructs you how to run CI validation. When I do so I get this error:
The text was updated successfully, but these errors were encountered: