Skip to content

Clippy emits some warnings on the nightly toolchain #2698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sarkahn opened this issue Aug 21, 2021 · 4 comments
Closed

Clippy emits some warnings on the nightly toolchain #2698

sarkahn opened this issue Aug 21, 2021 · 4 comments
Labels
C-Docs An addition or correction to our documentation D-Trivial Nice and easy! A great choice to get started with Bevy

Comments

@sarkahn
Copy link
Contributor

sarkahn commented Aug 21, 2021

I forked the repo to contribute and was reading through CONTRIBUTE.md, one of the steps instructs you how to run CI validation. When I do so I get this error:

clippy-error

@sarkahn sarkahn added C-Docs An addition or correction to our documentation S-Needs-Triage This issue needs to be labelled labels Aug 21, 2021
@bjorn3
Copy link
Contributor

bjorn3 commented Aug 21, 2021

Which rustc version are you using? If you are using beta or nightly clippy probably added a new lint or changed one to trigger in more cases.

@sarkahn
Copy link
Contributor Author

sarkahn commented Aug 21, 2021

Which rustc version are you using? If you are using beta or nightly clippy probably added a new lint or changed one to trigger in more cases.

You're right, I was using the nightly (1.56). When I switched back to 1.54 the error went away.

The getting started guide does list switching to nightly as a way to improve compilation times, so maybe this should still be fixed?

@NiklasEi NiklasEi added C-Code-Quality A section of code that is hard to understand or change and removed C-Docs An addition or correction to our documentation S-Needs-Triage This issue needs to be labelled labels Aug 21, 2021
@sarkahn sarkahn changed the title Following the instructions for "CONTRIBUTE.md" leads to a warning during local CI validation Clippy emits some warnings on the nightly toolchain Aug 21, 2021
@alice-i-cecile alice-i-cecile added C-Docs An addition or correction to our documentation D-Trivial Nice and easy! A great choice to get started with Bevy and removed C-Code-Quality A section of code that is hard to understand or change labels Aug 21, 2021
@alice-i-cecile
Copy link
Member

Yep, we should have a warning that small things of this nature may be broken when using nightly. That belongs in the book IMO, over on https://github.com/bevyengine/bevy-website.

@sarkahn
Copy link
Contributor Author

sarkahn commented Sep 9, 2021

As of the last rust update the false positive for collapsible-match on the nightly toolchain have been fixed. I update my pr to remove the #allows, and performing the steps from CONTRIBUTING.md no longer gives any errors:

cargo fmt --all -- --check (remove --check to let the command fix found problems)
cargo clippy --workspace --all-targets --all-features -- -D warnings -A clippy::type_complexity

@bors bors bot closed this as completed in 4c3c4b5 Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Docs An addition or correction to our documentation D-Trivial Nice and easy! A great choice to get started with Bevy
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants