Skip to content

Commit 0cbb9f7

Browse files
committed
msrv: only send a message on failure during the actual msrv part (#7532)
# Objective - In case of a CI failure before the MSRV check, like installing linux dependencies, a comment was still added to the PR ## Solution - Check that the actual MSRV step failed
1 parent 2e20d04 commit 0cbb9f7

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

.github/workflows/ci.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -332,14 +332,15 @@ jobs:
332332
- name: Install alsa and udev
333333
run: sudo apt-get update; sudo apt-get install --no-install-recommends libasound2-dev libudev-dev
334334
- name: Run cargo check
335+
id: check
335336
run: cargo check
336337
- name: Save PR number
337-
if: ${{ failure() && github.event_name == 'pull_request' }}
338+
if: ${{ failure() && github.event_name == 'pull_request' && steps.check.conclusion == 'failure' }}
338339
run: |
339340
mkdir -p ./msrv
340341
echo ${{ github.event.number }} > ./msrv/NR
341342
- uses: actions/upload-artifact@v2
342-
if: ${{ failure() && github.event_name == 'pull_request' }}
343+
if: ${{ failure() && github.event_name == 'pull_request' && steps.check.conclusion == 'failure' }}
343344
with:
344345
name: msrv
345346
path: msrv/

0 commit comments

Comments
 (0)