[Potentially breaking change] changed specs2 to single bind #319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chaoren I needed to change the aspect test for this to pass. |
ittaiz
changed the title
|
Also this will be a breaking change only to users who've customized specs2 usage |
|
Yes, it looks fine. It's even better now that the aspect test doesn't need to be changed every single time the dependencies change. |
|
Great.
If someone doesn't load the specs2_repositories and binds to its own target
which has different specs2 jars will the IDE be ok with it?
…On Sun, 22 Oct 2017 at 0:39 Chaoren Lin ***@***.***> wrote:
Yes, it looks fine. It's even better now that the aspect test doesn't need
to be changed every single time the dependencies change.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#319 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABUIF4pQGblMT5u4pRHygVLcWmSOEfkYks5sumRzgaJpZM4QBsx4>
.
|
|
It doesn't matter, since |
… (dependency graph changes)
ittaiz
force-pushed
the
specs2_binding
branch
from
1ce02e9 to
fd5a392
Compare
|
@johnynek I want to merge this one and #320 tomorrow since I have a backlog of stuff to upstream and just fix here:
|
|
@or-shachar wdyt? |
or-shachar
approved these changes
Oct 23, 2017
| "//external:io_bazel_rules_scala/dependency/scala/scala_library", | ||
| "//external:io_bazel_rules_scala/dependency/scala/scala_reflect" | ||
| ] | ||
| ) |
There was a problem hiding this comment.
[cosmetic] missing newline
| "//external:io_bazel_rules_scala/dependency/scala/parser_combinators", | ||
| "//external:io_bazel_rules_scala/dependency/scala/scala_library", | ||
| "//external:io_bazel_rules_scala/dependency/scala/scala_reflect"] | ||
| return ["//external:io_bazel_rules_scala/dependency/specs2/specs2"] |
There was a problem hiding this comment.
[cosmetic] - misssing newline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changed specs2 to single bind to remove volatility of version upgrade (dependency graph changes)
@johnynek following the discussion in #311 I realized my implementation was way off with the multiple binds.
This is a breaking change but I actually stumbled upon this need a few times in the past but I didn't realize the problem until your explanation in #311