-
Notifications
You must be signed in to change notification settings - Fork 39
High Resolution Metrics Support #96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
High Resolution Metrics Support #96
Conversation
disable implicit optional for mypy (awslabs#97)
Co-authored-by: Amruth Rayabagi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finished with the review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
PR Code Suggestions ✨
|
Description of changes:
Added support for High Resolution Metrics. Customers can specify an optional property - storageResolution of the metrics in putMetric() call. If resolution is not specified, metrics will be emitted with standard resolution.
Added UTs and modified integration tests for the changes.
Updated README.md and examples folder.
Updated the canary. See the image below for memory usage. (Note: We will have to wait until the feature is enabled to get metrics in high resolution for the canary)
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.