Support 30 dimensions per dimension set

[Himtanaya]

Issue #, if available:
N/A

Description of changes:

• Updates max dimension limit per dimension set to 30
• Throws exception if the limit is exceeded.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

[heitorlessa]

Wooow!! I checked EMF Spec and it's still 9 dimensions - is there a doc, What's new associated with this quota increase?

[Himtanaya]

Wooow!! I checked EMF Spec and it's still 9 dimensions - is there a doc, What's new associated with this quota increase?

We are still in the process of updating the documentation. As of now we are just getting the client libraries ready for the dimension limit update.

[giancarlokc]

Suggestion: Can we put this code behind a validateDimensionSet method? That way you can avoid duplication of this check and the exception.

[hussam789]

PR Code Suggestions ✨

Category	Suggestion	Impact
General	Clarify error message The error message is inconsistent with the actual validation. The code is checking the length of keys after they've already been extracted from the dimension set, but the error message refers to the dimension set size. This could be confusing for users debugging dimension limit issues. aws_embedded_metrics/serializers/log_serializer.py [35-38] if len(keys) > MAX_DIMENSION_SET_SIZE: - err_msg = (f"Maximum number of dimensions per dimension set allowed are {MAX_DIMENSION_SET_SIZE}. " + err_msg = (f"Maximum number of dimension keys allowed are {MAX_DIMENSION_SET_SIZE}. " f"Account for default dimensions if not using set_dimensions.") raise DimensionSetExceededError(err_msg) Apply this suggestion Suggestion importance[1-10]: 5 __ Why: This suggestion slightly improves the clarity of the error message by explicitly referring to keys instead of the overall dimension set. However, it is a minor stylistic change and does not impact functionality.	Low
	Fix grammar in error message The error message uses incorrect grammar. "Maximum number... are" should be "Maximum number... is". This makes the error message more professional and easier to understand. aws_embedded_metrics/logger/metrics_context.py [60-67] @staticmethod def validate_dimension_set(dimensions: Dict[str, str]) -> None: """ Validates dimension set length is not more than MAX_DIMENSION_SET_SIZE """ if len(dimensions) > MAX_DIMENSION_SET_SIZE: raise DimensionSetExceededError( - f"Maximum number of dimensions per dimension set allowed are {MAX_DIMENSION_SET_SIZE}") + f"Maximum number of dimensions per dimension set allowed is {MAX_DIMENSION_SET_SIZE}") Apply this suggestion Suggestion importance[1-10]: 5 __ Why: The suggested change corrects a grammatical issue in the error message, improving professionalism. It is a minor enhancement with limited impact on core functionality.	Low
More