Skip to content

Migrate canary to Fargate #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2021
Merged

Migrate canary to Fargate #68

merged 1 commit into from
Apr 8, 2021

Conversation

jaredcnance
Copy link
Member

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jaredcnance jaredcnance merged commit 24cc7e5 into master Apr 8, 2021
@jaredcnance jaredcnance deleted the jared/ci-fargate branch April 8, 2021 01:48
@hussam789
Copy link

PR Code Suggestions ✨

CategorySuggestion                                                                                                                                    Impact
Possible issue
Fix Fargate CPU specification

Fargate requires CPU values to be specified in vCPU units without the 'vcpu'
suffix. Use '256' (which equals 0.25 vCPU) instead of '0.25 vcpu' to avoid
deployment failures.

bin/deploy-canary.sh [49]

-+                        --cpu '0.25 vcpu' \
++                        --cpu 256 \

[To ensure code accuracy, apply this suggestion manually]

Suggestion importance[1-10]: 8

__

Why: The suggestion correctly identifies that Fargate expects a numeric CPU value and replaces the string with an appropriate integer value, directly addressing a potential deployment failure.

Medium
General
Improve container startup reliability

Installing packages at container runtime can lead to startup failures if package
repositories are unavailable. Move these installations to the Dockerfile build
phase for better reliability.

tests/canary/agent/start.sh [4-5]

-+pip3 install psutil > /dev/null
-+pip3 install getversion > /dev/null
++# These packages should be installed in the Dockerfile instead
++# Checking if already installed to prevent failures
++pip3 list | grep -q psutil || pip3 install psutil > /dev/null
++pip3 list | grep -q getversion || pip3 install getversion > /dev/null
  • Apply this suggestion
Suggestion importance[1-10]: 5

__

Why: Although moving package installation to the Dockerfile could enhance reliability, this change may conflict with the current design intent of installing dependencies at runtime; the suggestion is useful but its impact is moderate.

Low
  • More

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants