fix: remove constrain on pandas 1.5+ #2141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierresouchay
force-pushed
the
release_contraint_on_pandas
branch
from
089151d to
ced8839
Compare
pierresouchay
changed the title
pierresouchay
force-pushed
the
release_contraint_on_pandas
branch
from
ced8839 to
ebe087b
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Pandas 1.5.0 had a memory leak with awswrangler, but according to aws#1678 it is no longer the case. The current dependency expressed in pyproject.toml locks dependents to use only 1.5.1. Since the bug has been fixed in pandas we can now remove the lock.
pierresouchay
force-pushed
the
release_contraint_on_pandas
branch
from
ebe087b to
43eaa1b
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
jaidisido
approved these changes
Mar 22, 2023
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
kukushking
approved these changes
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pandas 1.5.0 had a memory leak with awswrangler,
but according to #1678 it is no longer the case.
The current dependency expressed in pyproject.toml locks dependents to use only 1.5.1. Since the bug has been fixed in pandas we can now remove the lock.
Feature or Bugfix
Detail
Relates
awswrangler.athena.read_sql_queryis leaking memory #1678By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.