feat(lambda): add LATEST to ParamsAndSecretsVersions #34367

okasyun · 2025-05-06T11:06:49Z

Issue # (if applicable)

Reason for this change

calling

cdk.aws_lambda.ParamsAndSecretsLayerVersion.fromVersion(cdk.aws_lambda.ParamsAndSecretsVersions.V1_0_103)

will always return the lambda layer with a version of 4 for us-east-1. the CDK documentation states that this is the latest version, while the documentation in lambda shows that 16 is the latest in this region.

Not only us-east-1 but also other resions have the same problems.

Description of changes

add property latest to ParamsAndSecretsVersions.

Parameters and Secrets Lambda Extension ARN can be referenced by using this latest.

Description of how you validated changes

I created unit tests and integration tests.
Both were successful.

Checklist

My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

aws-cdk-automation

(This review is outdated)

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

badmintoncryer

Thank you for your contribution! I've just added some minor modification to approve.

You're defining the latest correspondence relationships in fact-tables.ts, but to keep it up-to-date, we need to continuously update this file, which seems like it could result in breaking changes. I'd like you to discuss with the maintainers whether this approach is acceptable or not.

badmintoncryer · 2025-05-06T14:24:13Z

packages/aws-cdk-lib/aws-lambda/test/params-and-secrets.test.ts

+        },
+      },
+    });
+    expect(() => app.synth()).not.toThrow();


Suggested change

expect(() => app.synth()).not.toThrow();

badmintoncryer · 2025-05-06T14:24:23Z

packages/aws-cdk-lib/aws-lambda/test/params-and-secrets.test.ts

+        },
+      },
+    });
+    expect(() => app.synth()).not.toThrow();


Suggested change

expect(() => app.synth()).not.toThrow();

Thank you for the review.
I fixed the issues you pointed out in the following commit:
bc421c0

And, as you mentioned, fact-tables.ts will need to be continuously updated.
However, I couldn't come up with a better solution than this to add LATEST to ParamsAndSecretsVersions.
Although I'd like to discuss this with the maintainers, I'm not sure who they are.
If you know, could you let me know who I should reach out to?

In the console UI, you can only select a fixed AWS-Parameters-and-Secrets-Lambda-Extension version of the layer — there's no option to choose something like "latest" to always fetch the newest version.
For that reason, I believe the CDK should align with this behavior. Since the concept of a dynamically updated latest version isn't supported in the Lambda console, implementing such behavior in CDK is also challenging.

I couldn't come up with a better solution

I also have no better idea!

If you know, could you let me know who I should reach out to?

I'm not sure too. After my approval, the needs-maintainer-review label would be attached and one of maintainers will be assigned. Therefore, please wait until that time.

@badmintoncryer
I fix through this commit
050292a

badmintoncryer · 2025-05-08T00:37:24Z

@okasyun Could you please re-run your integ test?

@aws-cdk-testing/framework-integ: Snapshot Results: 
@aws-cdk-testing/framework-integ: Tests:    1 failed, 1186 total
@aws-cdk-testing/framework-integ: Failed: /codebuild/output/src1098740116/src/github.com/aws/aws-cdk/packages/@aws-cdk-testing/framework-integ/test/aws-lambda/test/integ.params-and-secrets.js
@aws-cdk-testing/framework-integ: Error: Some tests failed!
@aws-cdk-testing/framework-integ: To re-run failed tests run: integ-runner --update-on-failed
@aws-cdk-testing/framework-integ:     at main (/codebuild/output/src1098740116/src/github.com/aws/aws-cdk/node_modules/@aws-cdk/integ-runner/lib/index.js:10279:13)
@aws-cdk-testing/framework-integ: Error: integ-runner exited with error code 1
@aws-cdk-testing/framework-integ: Tests failed. Total time (2m19.0s) | integ-runner (2m8.0s) | /codebuild/output/src1098740116/src/github.com/aws/aws-cdk/node_modules/jest/bin/jest.js (9.9s)
@aws-cdk-testing/framework-integ: !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

badmintoncryer · 2025-05-08T13:42:21Z

@okasyun Could you please follow below steps?

Merge the newest origin/main
Run yarn at the repository root
Run npx lerna run build --scope=@aws-cdk-testing/framework-integ --skip-nx-cache
Delete the existing snapshot folder
Run the integ test

…rets tests

…ion to latest versions

aws-cdk-automation · 2025-05-11T10:02:13Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
Commit ID: 050292a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

scorbiere

Thanks for your contribution.

I made a couple of suggestions (took some inspiration from #32783)

scorbiere · 2025-05-16T18:37:12Z

packages/aws-cdk-lib/aws-lambda/lib/params-and-secrets-layers.ts

  V1_0_103 = '1.0.103',
+  /**
+   * latest version
+   *
+   */
+  LATEST = 'latest',


Suggested change

V1_0_103 = '1.0.103',

/**

* latest version

*

*/

LATEST = 'latest',

V1_0_103 = '1.0.103',

/**

* Version 1.0.104

*/

V1_0_104 = '1.0.104',

/**

* latest version

*/

LATEST = '1.0.104',

scorbiere · 2025-05-16T18:39:07Z

packages/aws-cdk-lib/region-info/build-tools/fact-tables.ts

@@ -1243,6 +1243,84 @@ export const PARAMS_AND_SECRETS_LAMBDA_LAYER_ARNS: { [version: string]: { [arch:
      'us-west-2': 'arn:aws:lambda:us-west-2:345057560386:layer:AWS-Parameters-and-Secrets-Lambda-Extension-Arm64:4',
    },
  },
+  'latest': {


I would suggest to keep the version logic and to keep the new entry in 1st position:

Suggested change

'latest': {

'1.0.104': {

aws-cdk-automation requested a review from a team May 6, 2025 11:06

github-actions bot added p2 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. labels May 6, 2025

aws-cdk-automation previously requested changes May 6, 2025

View reviewed changes

aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label May 6, 2025

badmintoncryer suggested changes May 6, 2025

View reviewed changes

aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label May 7, 2025

okasyun force-pushed the feature/add-latest-params-and-secrets-versions branch 2 times, most recently from ed1ab42 to bc421c0 Compare May 7, 2025 10:01

okasyun added 5 commits May 11, 2025 15:02

feat(lambda): add LATEST to ParamsAndSecretsVersions

845c8ce

docs(codebuild): update README.md

10e08a9

fix(lambda): remove redundant synthesis expectation in params and sec…

76d92e7

…rets tests

fix(lambda): update ARNs for AWS Parameters and Secrets Lambda Extens…

80845ea

…ion to latest versions

fix(lambda): update snapshots

4528bc8

okasyun force-pushed the feature/add-latest-params-and-secrets-versions branch from 8020755 to 4528bc8 Compare May 11, 2025 06:43

fix(lambda): update unit test

050292a

scorbiere self-assigned this May 16, 2025

scorbiere reviewed May 16, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(lambda): add LATEST to ParamsAndSecretsVersions #34367

feat(lambda): add LATEST to ParamsAndSecretsVersions #34367

Uh oh!

okasyun commented May 6, 2025 •

edited

Loading

Uh oh!

aws-cdk-automation left a comment •

edited

Loading

Uh oh!

badmintoncryer left a comment

Uh oh!

badmintoncryer May 6, 2025

Uh oh!

badmintoncryer May 6, 2025

Uh oh!

okasyun May 7, 2025 •

edited

Loading

Uh oh!

okasyun May 7, 2025

Uh oh!

badmintoncryer May 8, 2025 •

edited

Loading

Uh oh!

okasyun May 11, 2025

Uh oh!

badmintoncryer commented May 8, 2025

Uh oh!

badmintoncryer commented May 8, 2025

Uh oh!

aws-cdk-automation commented May 11, 2025

Uh oh!

scorbiere left a comment

Uh oh!

scorbiere May 16, 2025

Uh oh!

scorbiere May 16, 2025

Uh oh!

Uh oh!

feat(lambda): add LATEST to ParamsAndSecretsVersions #34367

Are you sure you want to change the base?

feat(lambda): add LATEST to ParamsAndSecretsVersions #34367

Uh oh!

Conversation

okasyun commented May 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue # (if applicable)

Reason for this change

Description of changes

Description of how you validated changes

Checklist

Uh oh!

aws-cdk-automation left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

badmintoncryer left a comment

Choose a reason for hiding this comment

Uh oh!

badmintoncryer May 6, 2025

Choose a reason for hiding this comment

Uh oh!

badmintoncryer May 6, 2025

Choose a reason for hiding this comment

Uh oh!

okasyun May 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

okasyun May 7, 2025

Choose a reason for hiding this comment

Uh oh!

badmintoncryer May 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

okasyun May 11, 2025

Choose a reason for hiding this comment

Uh oh!

badmintoncryer commented May 8, 2025

Uh oh!

badmintoncryer commented May 8, 2025

Uh oh!

aws-cdk-automation commented May 11, 2025

AWS CodeBuild CI Report

Uh oh!

scorbiere left a comment

Choose a reason for hiding this comment

Uh oh!

scorbiere May 16, 2025

Choose a reason for hiding this comment

Uh oh!

scorbiere May 16, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

okasyun commented May 6, 2025 •

edited

Loading

aws-cdk-automation left a comment •

edited

Loading

okasyun May 7, 2025 •

edited

Loading

badmintoncryer May 8, 2025 •

edited

Loading