Skip to content

fix: pin FluentAssertions NuGet version to prevent license issues #698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

ankitdhaka07
Copy link

@ankitdhaka07 ankitdhaka07 commented Jan 15, 2025

… changes

Issue Number : 697

Summary

Changes

The commit updates the Directory.Packages.props file to pin the FluentAssertions NuGet package version by surrounding the version number with square brackets to prevent unintentional upgrades.

User experience

Checklist

Please leave checklist items unchecked if they do not apply to your change.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@auto-assign auto-assign bot requested a review from amirkaws January 15, 2025 18:31
@boring-cyborg boring-cyborg bot added the tests label Jan 15, 2025
@auto-assign auto-assign bot requested review from hjgraca and sliedig January 15, 2025 18:31
Copy link

boring-cyborg bot commented Jan 15, 2025

Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need.
In the meantime, check out the #dotnet channel on our Powertools for AWS Lambda Discord: Invite link

@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 15, 2025
Copy link

@hjgraca
Copy link
Contributor

hjgraca commented Jan 16, 2025

Thank you @ankitdhaka07 for the contribution!

@github-actions github-actions bot added the bug Unexpected, reproducible and unintended software behaviour label Jan 16, 2025
Copy link

No related issues found. Please ensure there is an open issue related to this change to avoid significant delays or closure.

@github-actions github-actions bot added do-not-merge PRs that are blocked for varying reasons need-issue PR is missing a related issue for tracking change labels Jan 16, 2025
Copy link
Contributor

@hjgraca hjgraca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@hjgraca hjgraca self-assigned this Jan 16, 2025
@hjgraca hjgraca merged commit cef7dd6 into aws-powertools:develop Jan 16, 2025
9 checks passed
Copy link

boring-cyborg bot commented Jan 16, 2025

Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience!

@dreamorosi dreamorosi linked an issue Jan 16, 2025 that may be closed by this pull request
1 task
@ankitdhaka07
Copy link
Author

Happy to make my first open source contribution :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Unexpected, reproducible and unintended software behaviour do-not-merge PRs that are blocked for varying reasons need-issue PR is missing a related issue for tracking change size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: Pin FluentAssertions NuGet version
2 participants